This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Add a formatter to compactly print stack traces #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Produces a similar format to the native PHP exception handler
|
You changed the php constrained in the |
froschdesign
suggested changes
Oct 12, 2017
| $event['timestamp'] = $event['timestamp']->format($this->getDateTimeFormat()); | ||
| } | ||
|
|
||
| $output = '[' . $event['timestamp'] . '] ' . $event['priorityName'] . ' (' |
There was a problem hiding this comment.
These lines are very hard to read. Please use sprintf.
| if (! empty($event['extra']['trace'])) { | ||
| $output .= "Stack trace:\n"; | ||
| foreach ($event['extra']['trace'] as $i => $traceLine) { | ||
| $output .= "#$i " . $this->formatTraceLine($traceLine) . "\n"; |
There was a problem hiding this comment.
Same here. (Don't use "#$i ".)
| } | ||
|
|
||
| /** | ||
| * {@inheritDoc} |
There was a problem hiding this comment.
| } | ||
|
|
||
| /** | ||
| * {@inheritDoc} |
| @@ -0,0 +1,164 @@ | |||
| <?php | |||
| /** | |||
| * Zend Framework (http://framework.zend.com/) | |||
There was a problem hiding this comment.
Please replace the header with this:
/**
* @see https://github.com/zendframework/zend-log for the canonical source repository
* @copyright Copyright (c) 2015-2017 Zend Technologies USA Inc. (http://www.zend.com)
* @license https://github.com/zendframework/zend-log/blob/master/LICENSE.md New BSD License
*/| @@ -0,0 +1,63 @@ | |||
| <?php | |||
| /** | |||
| * Zend Framework (http://framework.zend.com/) | |||
There was a problem hiding this comment.
Please replace the header with this:
/**
* @see https://github.com/zendframework/zend-log for the canonical source repository
* @copyright Copyright (c) 2015-2017 Zend Technologies USA Inc. (http://www.zend.com)
* @license https://github.com/zendframework/zend-log/blob/master/LICENSE.md New BSD License
*/
|
Bit of a misunderstanding, turns out our company will not be using this library in the near future. I'm closing the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The available formatters are very verbose. This one produces a similar format to the native PHP exception handler.
It could use some more tests.
The type of the exception is not printed, it is not available in the event.
Solves #32 if you use this formatter
PHP version is bumped to 7.0 to use the coalesce operator and more type hints