Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Fix a sequence name with double quotes for PostgreSQL to preserve nam… #118

Closed

Conversation

alexsds
Copy link

@alexsds alexsds commented Jun 25, 2016

…e registry when try to get last sequence id
See description for bug (zendframework/zendframework#6222)

@alexsds
Copy link
Author

alexsds commented Jul 6, 2016

hello @weierophinney. Please send feedback

@alexsds alexsds force-pushed the psql_last_sequence_id_fix branch from 0a10aaa to b35210d Compare July 11, 2016 16:57
@mwillbanks
Copy link
Contributor

@alexsds This has not been reviewed because it breaks the unit tests, fix the tests so that it passes and we can then review for inclusion.

@alexsds alexsds force-pushed the psql_last_sequence_id_fix branch 8 times, most recently from c6bf0db to aa2118b Compare August 9, 2016 19:20
…e registry when try to get last sequence id
@alexsds alexsds force-pushed the psql_last_sequence_id_fix branch from aa2118b to d31efc6 Compare August 9, 2016 19:55
@alexsds
Copy link
Author

alexsds commented Aug 9, 2016

@mwillbanks fixed tests

@ezimuel
Copy link
Contributor

ezimuel commented Dec 4, 2017

@alextech this PR is covered by your #187 ?

@alextech
Copy link
Contributor

alextech commented Dec 4, 2017

@ezimuel yes

@ezimuel
Copy link
Contributor

ezimuel commented Aug 6, 2018

Closing in favor of #187

@ezimuel ezimuel closed this Aug 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants