Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Add alive option to ls #3510

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Odilf
Copy link

@Odilf Odilf commented Jul 19, 2024

Closes #3168

In the end, I added the flag with the name alive, which I think is reasonable. Of course it can still be bikeshed, but since the issue hadn't had activity for a few months so I decided to go forward with what I think sounds best!

I think it might make sense to only show alive session by default and have another --exited or --show-exited flag, but that would change the current behavior, so I figured I'd let a maintainer take that decision.

As an FYI, I tried to run and test everything locally, but I couldn't get it to compile (the problem is some missing target/../wasm32-wasi/... plugin thingy) but the changes seem simple so I hope it just works 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --alive option for ls
1 participant