Skip to content

Commit

Permalink
Enable continue on error
Browse files Browse the repository at this point in the history
Signed-off-by: Zelin Hao <[email protected]>
  • Loading branch information
zelinh committed Dec 6, 2023
1 parent aaf38f8 commit 8e1a088
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions src/build_workflow/build_incremental.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ def build_incremental(self, args: BuildArgs, input_manifest: InputManifest, comp

# output_dir = BuildOutputDir(input_manifest.build.filename, args.distribution).dir
output_dir = BuildOutputDir("temp", args.distribution).dir
failed_plugins = []

with TemporaryDirectory(keep=args.keep, chdir=True) as work_dir:
logging.info(f"Building in {work_dir.name}")
Expand Down Expand Up @@ -123,8 +124,16 @@ def build_incremental(self, args: BuildArgs, input_manifest: InputManifest, comp
logging.info(f"Successfully built {component.name}")
except:
logging.error(f"Error building {component.name}, retry with: {args.component_command(component.name)}")
if args.continue_on_error and component.name not in ['OpenSearch', 'job-scheduler', 'common-utils', 'OpenSearch-Dashboards']:
failed_plugins.append(component.name)
continue
else:
raise
build_recorder_incremental.write_manifest()

if len(failed_plugins) > 0:
logging.error(f"Failed plugins are {failed_plugins}")
logging.info("Done.")



Expand Down

0 comments on commit 8e1a088

Please sign in to comment.