[Global Disputes] Fix issues after first battery station live test #912

Chralt98 · 2022-12-15T14:57:41Z

Fixes #928

Add possession which can be either Shared or Paid
- this allows to distinguish between the extrinsic call add_vote_outcome, which is always paid with a VotingOutcomeFee and the private API call push_vote_outcome, which allows multiple (shared) owners
add new storage item GlobalDisputesInfo and put the content of Winners inside this
- rename was necessary, because Winners doesn't suit the point of this storage item anymore
- prepared to get Winners storage item removed after the runtime upgrade
Storage Migrations were necessary to adapt to the new possession enum field
add_vote_outcome now checks for the outcome type now
- for example: on scalar markets, the global dispute should only allow scalar outcomes
allow to destroy a global dispute to unlock and return all user funds
return NoFundsToReward error for reward_outcome_owner, when add_vote_outcome was never called (so no funds available)
Added AddOutcomePeriod and VotePeriod to allow the addition of vote outcomes only before the voting starts
- the benefit is to make it harder to get clone outcomes (for scalar markets), because voters have the full and unchangeable set of vote outcomes in front of them

zrml/global-disputes/src/lib.rs

maltekliemann

Nice job.

I guess the fact that global-disputes didn't rely on actually working with a market should have tipped us off sooner. No harm done, though. But I have one question regarding this pallet: I find it difficult to tell at which point a global dispute actually starts. The Winners map tracks the status of the global-dispute, which is initialize when the first voting outcome is pushed, correct?

I think it might be easier to expose a function start_global_dispute which creates an object which then tracks the status of the global dispute (could be the Winners object) and which performs all the necessary checks that need to be made in order to start the dispute (for example, there exists a market, the market has the correct state, etc.), much like create_pool (note that create_pool is not an extrinsic). It's definitely not ideal to combine the creation of a global dispute with push_voting_outcome. It's a design smell, and you're also doing a lot of unnecessary work (checking the validity of the market everytime someone adds a new outcome).

zrml/global-disputes/src/tests.rs

maltekliemann · 2022-12-17T12:10:33Z

zrml/global-disputes/src/lib.rs

@@ -221,6 +225,9 @@ mod pallet {
        ) -> DispatchResultWithPostInfo {
            let owner = ensure_signed(origin)?;

+            let market = T::MarketCommons::market(&market_id)?;
+            ensure!(market.matches_outcome_report(&outcome), Error::<T>::OutcomeMismatch);


It would make more sense to me to put this into push_vote_outcome. If you call push_vote_outcome from some other function and forget to verify that the outcome types match, then we'll have another bug.

add_vote_outcome is different to push_voting_outcome. add_vote_outcome is controlled by a user. So, I would be in favour of blocking a user to put in a combinatoric outcome instead of a scalar outcome.

But add_vote_outcome is implemented using push_voting_outcome. That's why I suggested it. You have a clean API, i.e. other pallets can't accidentally push incorrect outcomes, and neither can users.

now decoupled

zeitgeist/zrml/global-disputes/src/lib.rs

Lines 263 to 267 in 6611b25

Self::update_winner(&market_id, &outcome, voting_outcome_fee);

let possession =

Some(Possession::Paid { owner: owner.clone(), fee: voting_outcome_fee });

let outcome_info = OutcomeInfo { outcome_sum: voting_outcome_fee, possession };

<Outcomes<T>>::insert(market_id, outcome.clone(), outcome_info);

after this change I suspect time complexity of this extrinsic has changed, and perhaps weight computation is also changed.

Yeah, that's true.

Not sure what was done to resolve this problem.

It's just I said above. add_vote_outcome did use push_vote_outcome, but now it's decoupled, so the logic of add_vote_outcome is now independent from push_vote_outcome with this

zeitgeist/zrml/global-disputes/src/lib.rs

Lines 263 to 267 in 6611b25

Self::update_winner(&market_id, &outcome, voting_outcome_fee);

let possession =

Some(Possession::Paid { owner: owner.clone(), fee: voting_outcome_fee });

let outcome_info = OutcomeInfo { outcome_sum: voting_outcome_fee, possession };

<Outcomes<T>>::insert(market_id, outcome.clone(), outcome_info);

maltekliemann · 2022-12-17T12:12:52Z

zrml/global-disputes/src/tests.rs

+        GlobalDisputes::push_voting_outcome(
+            &market_id,
+            OutcomeReport::Scalar(0),
+            &ALICE,
+            10 * BASE,
+        )
+        .unwrap();


This should fail. I mean... why would it be okay to push an outcome for a non-existent market?

True, it is just like, that we are in full control of the private API calls like push_voting_outcome and determine_voting_winner. So it's not really needed, because the market check is always inside prediction-markets before the private API calls.

Depends on what you mean by private, I guess. If you think of zrml_global_disputes as the object, then the object exposes an API to other pallets. These pallets are now able to push different types of outcome tokens to a global dispute, which is a violation of the rules of zrml_global_disputes. Fans of OOP will tell you that's dangerous. In general, I would agree with that sentiment.

That being said, OOP isn't always perfect. There are reasons why an API would not check the input. Sometimes its too costly, sometimes virtually impossible. It's your call.

zrml/global-disputes/src/tests.rs

maltekliemann · 2022-12-18T12:31:52Z

By the way, how does global-disputes react when a market for which a global dispute is currently under way is destroyed?

Chralt98 · 2022-12-19T14:51:12Z

By the way, how does global-disputes react when a market for which a global dispute is currently under way is destroyed?

Good question. I did not think about this scenario. It seems fatal. Maybe good to have this in this PR.

When a global dispute is already started and the market is destroyed afterwards, it would block add_vote_outcome now. All other extrinsics in the pallet are not stopped. The problem comes, when we don't resolve the market, because the global dispute never finishes then. This means, that all funds are locked in the destroyed market.

zeitgeist/zrml/prediction-markets/src/lib.rs

Line 2687 in 8281fbf

let market = <zrml_market_commons::Pallet<T>>::market(id)?;

We can fix this by calling T::GlobalDisputes::determine_voting_winner(market_id) inside admin_destroy_market. Or we should probably add another private API call to immediately stop a global dispute and return all funds. Thanks for this nice thought experiment. Loved that

Chralt98 · 2022-12-20T08:09:17Z

Should we rather return an error here ? I think this makes more sense. Added commit 8d6bcac

maltekliemann · 2022-12-30T20:15:12Z

Should we rather return an error here ? I think this makes more sense. Added commit 8d6bcac

Sorry, not quite sure what you're asking. Can you provide some context to the whole ownership thing? I just glanced over it. Looks like it might require a storage migration.

Generally regarding destroying markets: It's quite possible that there's no more need to destroy markets. Markets with corrupted storage can be fixed via migration/democracy and unwanted markets will be dealt with via blacklisting. But we should wait until the proposal is done and we've had a chance to review the consequences of removing admin_destroy_market. So right now, it's definitely the cleanest solution to make this pallet "resistant" to destroying markets.

Chralt98 · 2023-01-02T13:38:37Z

Sorry, not quite sure what you're asking. Can you provide some context to the whole ownership thing?

We have the users, who add outcomes with the extrinsic. These users pay a voting outcome fee.

There can only be one owner for a particular outcome. So, we don't need to handle a list of owners.

On the other hand we have outcomes from the disputes, which can have multiple owners. For one disputed outcome, there could be two disputors in the current implementation of prediction-markets.

I just glanced over it. Looks like it might require a storage migration.

True, it requires a storage migration. I had no time so far for this.

Makefile

Chralt98 · 2023-08-23T09:19:19Z

zrml/global-disputes/src/lib.rs

+                            &Self::reward_account(&market_id),
+                            &owner,
+                            fee,
+                            ExistenceRequirement::AllowDeath,


zeitgeist/runtime/common/src/lib.rs

Lines 192 to 202 in 97e4dcc

pallets.push(GlobalDisputesPalletId::get());

if let Some(pallet_id) = frame_support::PalletId::try_from_sub_account::<u128>(ai) {

return pallets.contains(&pallet_id.0);

}

for pallet_id in pallets {

let pallet_acc: AccountId = pallet_id.into_account_truncating();

if pallet_acc == *ai {

return true;

yes.

Chralt98 · 2023-08-23T09:22:35Z

zrml/global-disputes/src/lib.rs

@@ -221,6 +225,9 @@ mod pallet {
        ) -> DispatchResultWithPostInfo {
            let owner = ensure_signed(origin)?;

+            let market = T::MarketCommons::market(&market_id)?;
+            ensure!(market.matches_outcome_report(&outcome), Error::<T>::OutcomeMismatch);


It's just I said above. add_vote_outcome did use push_vote_outcome, but now it's decoupled, so the logic of add_vote_outcome is now independent from push_vote_outcome with this

zeitgeist/zrml/global-disputes/src/lib.rs

Lines 263 to 267 in 6611b25

Self::update_winner(&market_id, &outcome, voting_outcome_fee);

let possession =

Some(Possession::Paid { owner: owner.clone(), fee: voting_outcome_fee });

let outcome_info = OutcomeInfo { outcome_sum: voting_outcome_fee, possession };

<Outcomes<T>>::insert(market_id, outcome.clone(), outcome_info);

sea212 · 2023-08-23T13:10:41Z

zrml/global-disputes/src/weights.rs

    }
-    // Storage: GlobalDisputes Winners (r:1 w:1)
+    // Storage: GlobalDisputes GlobalDisputesInfo (r:1 w:1)
    // Storage: GlobalDisputes Outcomes (r:3 w:2)
    fn purge_outcomes(k: u32, _o: u32) -> Weight {


Why is the parameter _o ignored here?

Somehow the benchmark doesn't recognise the dynamic vector of owners as significant enough..

zeitgeist/zrml/global-disputes/src/benchmarks.rs

Lines 412 to 419 in b792304

for i in 1..=o {

let owner = account("winners_owner", i, 0);

owners.push(owner);

}

let owners = BoundedVec::try_from(owners.clone()).unwrap();

let winner_outcome = OutcomeReport::Scalar(0);

let possession = Possession::Shared { owners };

Although it is read here.

sea212 · 2023-08-23T13:16:04Z

zrml/global-disputes/src/migrations.rs

+        T: Config,
+    {
+        let mut total_weight = T::DbWeight::get().reads(1);
+        let gd_version = StorageVersion::get::<GDPallet<T>>();


STORAGE_VERSION was previously undefined, not sure if it returns 0 in that case (probably it does).

https://paritytech.github.io/substrate/master/src/frame_support/traits/metadata.rs.html#219

get_or_default smells like using 0 if not defined

mergify · 2023-08-23T14:07:13Z

This pull request is now in conflicts. Could you fix it @Chralt98? 🙏

* ZIP-0 Part II (#938) * move disputes to simple-disputes * move more to simple-disputes * wip * wip * some mock preparation * wip * fix tests * taplo fmt * update court authorized mdms * add dispute bond to market storage * mdm funds flow * fix clippy * fix pm benchmarks * add migration * simplify migration * correct migration * migration fixes and call filter * correct admin_destroy_market benchmark * improve simple-disputes mock * benchmark reserve_outcome * benchmark reserve_outcome * fix weights file * fix after merge * add migration tests * add migration reserve id test * apply review suggestions * rename reserve_outcome to suggest_outcome * separate resolve_disputed_market into parts * edit exchange API documentation * slash dispute bond * add empty commit * correct admin_destroy_market test * remove gd dependency from simple disputes * Update zrml/simple-disputes/src/mock.rs Co-authored-by: Harald Heckmann <[email protected]> * Update zrml/simple-disputes/src/mock.rs Co-authored-by: Harald Heckmann <[email protected]> * Update zrml/prediction-markets/src/lib.rs Co-authored-by: Harald Heckmann <[email protected]> * add doc string * add doc strings * Reduce settle_bonds LOC * cargo fmt * Update zrml/prediction-markets/src/migrations.rs Co-authored-by: Harald Heckmann <[email protected]> * Update zrml/prediction-markets/src/migrations.rs Co-authored-by: Harald Heckmann <[email protected]> * apply review suggestion * add correct mdm benchmarking on_dispute * use on_dispute_weight inside api * improve mdm weight technique * add mdm weights to on_resolution * add tests for pm * modify migration logs, fix try-runtime * little benchmark fix * Update zrml/authorized/src/benchmarks.rs Co-authored-by: Harald Heckmann <[email protected]> * Update zrml/authorized/src/benchmarks.rs Co-authored-by: Harald Heckmann <[email protected]> * use result with weight struct * improve dispute api weight system * Use accurate dispute weight instead of max * fix clippy * Update zrml/prediction-markets/src/migrations.rs Co-authored-by: Malte Kliemann <[email protected]> * add copyrights --------- Co-authored-by: Harald Heckmann <[email protected]> Co-authored-by: Malte Kliemann <[email protected]> * fix clippy * fix clippy * Update dependencies to v0.9.38 * More dependency updates * Update standalone runtimes * Fix build with feature runtime-benchmark * Update Zeitgeist parachain runtime * Update Battery Station parachain runtime * Deduplicated dependencies * Make tests succeed for parachain runtime * Partially fix Zeitgeist xcm tests * Make all runtime tests succeed * Update standalone client * Update parachain node * Add migrations * Cargo fmt * Satisfy Clippy * Cargo fmt * Taplo format * Update licenses * remove outsider bond from migration * Reduce runtime test dependencies by half * small changes * Add missing runtime-benchmark feature * Use upper case copyright name Strange, locally the copyright script says: "All copyright notices are up to date! 🍉" On GH pipeline: "error: zrml/prediction-markets/src/benchmarks.rs: no copyright notice for Forecasting Technologies LTD found" * Remove test logger * Implement Production Court (#976) * apply review suggestions * rename reserve_outcome to suggest_outcome * separate resolve_disputed_market into parts * add debug asserts * document types * modify sort check * avoid double remove * clarify docs * avoid mut * binary search by account id * Revert "binary search by account id" This reverts commit c04d5ff. * make pool item key unique * use secure random number generator * add tests * add tests * found bug in exit court * correct slashable * fix exit court * correct tests * fix bug, add tests * fix second get_winner bug * modify tests * fix draw active lock bug, add tests * rename total_slashable to consumed_stake * update config parameters, tests * modify params and add tests * add denounce tests * increase code safety * add tests * add tests * edit exchange API documentation * slash dispute bond * add empty commit * correct admin_destroy_market test * revert get_resolution_outcome to on_resolution * remove gd dependency from simple disputes * use appealed outcomes for global dispute * modify appeal bond formula * remove slash percentages * benchmark court * Update zrml/court/src/types.rs Co-authored-by: Malte Kliemann <[email protected]> * Update zrml/court/src/types.rs Co-authored-by: Malte Kliemann <[email protected]> * Update zrml/court/src/lib.rs Co-authored-by: Malte Kliemann <[email protected]> * Update zrml/court/src/lib.rs Co-authored-by: Malte Kliemann <[email protected]> * Update zrml/court/src/lib.rs Co-authored-by: Malte Kliemann <[email protected]> * Update zrml/court/src/mock_storage.rs Co-authored-by: Malte Kliemann <[email protected]> * Update zrml/court/src/lib.rs Co-authored-by: Malte Kliemann <[email protected]> * Update zrml/court/src/lib.rs Co-authored-by: Malte Kliemann <[email protected]> * Update zrml/court/src/tests.rs Co-authored-by: Malte Kliemann <[email protected]> * Update zrml/court/src/tests.rs Co-authored-by: Malte Kliemann <[email protected]> * periods to round timing, modify tests * modify doc comments * use onunbalanced * improve RequestInterval documentation * improve consumed_stake documentation * remove court from filter * add treasury to court * correct errors * update comment * update get_pool_item comment * update get_pool_item comment * comment juror pool * improve doc comments * cargo fmt * rename constants * edit court pallet doc * update tests * rename secret to commitment * make commit reveal failsafer * outsource commitment function * update doc comments * merge punish tardy jurors reassign juror stakes * outsource get_n_random_numbers * correct logs * rename default to get * improve extrinsic comments * simplify choose_multiple_weighted * improve naming * remove back_global_dispute * unlock jurors from last draws * improve error description * shorten mock periods * document private functions * add assert to check max appeals * add stake to juror joined event * correct test * improve test * update reassigned event comment * correct test * add assert check * improve tests for draws * add reveal vote invalid salt fails test * denounce slash inside reassign_juror_stakes * improve test readibility * rename periods to cycle_ends * add select jurors test * change randomness source in court tests * fix clippy * imrpove tests * remove cccount lookup in tests * improve test setup * add API tests, add missing unlockings * add full cycle court tests * remove invalid test * add missing WeightInfo * add inflation inside court * improve benchmarking and testing * add integrity_test * Update zrml/simple-disputes/src/mock.rs Co-authored-by: Harald Heckmann <[email protected]> * Update zrml/simple-disputes/src/mock.rs Co-authored-by: Harald Heckmann <[email protected]> * Update zrml/prediction-markets/src/lib.rs Co-authored-by: Harald Heckmann <[email protected]> * add doc string * add doc strings * Reduce settle_bonds LOC * cargo fmt * Update zrml/prediction-markets/src/migrations.rs Co-authored-by: Harald Heckmann <[email protected]> * Update zrml/prediction-markets/src/migrations.rs Co-authored-by: Harald Heckmann <[email protected]> * apply review suggestion * add GDItem integration * add delegations * improve code structure * fix benchmarks * optimize logic * add correct mdm benchmarking on_dispute * use on_dispute_weight inside api * improve mdm weight technique * add mdm weights to on_resolution * add tests for pm * modify migration logs, fix try-runtime * adjust tests for binary search * improve benchmarking * do small change * little benchmark fix * Update zrml/authorized/src/benchmarks.rs Co-authored-by: Harald Heckmann <[email protected]> * Update zrml/authorized/src/benchmarks.rs Co-authored-by: Harald Heckmann <[email protected]> * use result with weight struct * improve code * update benchmark and weights * improve dispute api weight system * test delegations for reassign * correct benchmarks and test * remove comment * add API benchmarks * update weights * use generic vote item instead of outcome report * update to court id and generic court * fix stuff and add documentation * add court readme, use new parameters * improve naming, weighting * Use accurate dispute weight instead of max * take random ranges without replacement * switch get_random_number algo * integrate court and reject simple disputes * update start_global_dispute bench * fix clippy * use efficient draw without replacement algorithm * small edits * round to min juror stake, use other draw algo * use partial fisher yates algorithm * improve naming and comments * update changelog for devs * improve dispute api documentation * correct call filters * add copyright notice * remove is_outcome and is_binary * remove unnecessary "Court" prefix * update copyright notices * remove front end comment * Update zrml/court/README.md Co-authored-by: Malte Kliemann <[email protected]> * npx prettier court readme * improve style of terminology * update readme * remove unnecessary impl block * update comment * remove todo * make reward_pot package private * Update zrml/court/src/lib.rs Co-authored-by: Malte Kliemann <[email protected]> * update integrity test * improve join court doc * improve extrinsic documentation * update delegate doc * make some types package private * fix struct comment * update readme * update readme * remove commitment matcher * fix doc string * remove unnecessary error * improve import * improve test case * fix inflation misbehaviour * improve round timing structure * improve error names * fix get_valid_delegated_juror * remove wrong break * update weight for select jurors * allow rejoin after exit preparation * remove unnecessary apis * improve naming and docs * fix clippy * fix copyrights * update changelog for devs * Update runtime/common/src/lib.rs Co-authored-by: Harald Heckmann <[email protected]> * Update zrml/court/src/lib.rs Co-authored-by: Harald Heckmann <[email protected]> * Update zrml/court/src/benchmarks.rs Co-authored-by: Harald Heckmann <[email protected]> * comment benchmark components * comment benchmark component * Update zrml/court/README.md Co-authored-by: Harald Heckmann <[email protected]> * add terminology for court * Update zrml/prediction-markets/src/benchmarks.rs Co-authored-by: Harald Heckmann <[email protected]> * restructure import * Update zrml/court/src/lib.rs Co-authored-by: Harald Heckmann <[email protected]> * Update zrml/court/src/lib.rs Co-authored-by: Harald Heckmann <[email protected]> * Update zrml/court/src/lib.rs Co-authored-by: Harald Heckmann <[email protected]> * use mul_floor and reduce indentation * safe guard inflation emission * use imbalance for minting * use saturated div * logging if inflation period mint too high * Update zrml/court/src/lib.rs Co-authored-by: Harald Heckmann <[email protected]> * reduce court InflationPeriod for Battery Station * Update zrml/court/src/lib.rs Co-authored-by: Harald Heckmann <[email protected]> * fmt * fix tests * fix issue tokens without burn * remove unnecessary error return * allow equal amount to previous stake --------- Co-authored-by: Malte Kliemann <[email protected]> Co-authored-by: Harald Heckmann <[email protected]> * [Global Disputes] Fix issues after first battery station live test (#912) * apply review suggestions * use keep alive * cargo fmt * use function instead of raw * improve documentation * improve 2 outcome check * start gd requires two unqiue outcomes * fix error * add empty commit * correct admin_destroy_market test * revert get_resolution_outcome to on_resolution * remove gd dependency from simple disputes * fix clippy * use appealed outcomes for global dispute * fix tests and benchmarks * modify appeal bond formula * remove slash percentages * test default toolchain * benchmark court * Update zrml/court/src/types.rs Co-authored-by: Malte Kliemann <[email protected]> * Update zrml/court/src/types.rs Co-authored-by: Malte Kliemann <[email protected]> * Update zrml/court/src/lib.rs Co-authored-by: Malte Kliemann <[email protected]> * Update zrml/court/src/lib.rs Co-authored-by: Malte Kliemann <[email protected]> * Update zrml/court/src/lib.rs Co-authored-by: Malte Kliemann <[email protected]> * Update zrml/court/src/mock_storage.rs Co-authored-by: Malte Kliemann <[email protected]> * Update zrml/court/src/lib.rs Co-authored-by: Malte Kliemann <[email protected]> * Update zrml/court/src/lib.rs Co-authored-by: Malte Kliemann <[email protected]> * Update zrml/court/src/tests.rs Co-authored-by: Malte Kliemann <[email protected]> * Update zrml/court/src/tests.rs Co-authored-by: Malte Kliemann <[email protected]> * periods to round timing, modify tests * modify doc comments * use onunbalanced * improve RequestInterval documentation * improve consumed_stake documentation * remove court from filter * add treasury to court * correct errors * update comment * update get_pool_item comment * update get_pool_item comment * comment juror pool * improve doc comments * cargo fmt * rename constants * edit court pallet doc * update tests * rename secret to commitment * make commit reveal failsafer * outsource commitment function * Update scripts/tests/misc.sh * update doc comments * merge punish tardy jurors reassign juror stakes * outsource get_n_random_numbers * correct logs * rename default to get * improve extrinsic comments * simplify choose_multiple_weighted * improve naming * remove back_global_dispute * unlock jurors from last draws * improve error description * shorten mock periods * document private functions * add assert to check max appeals * add stake to juror joined event * correct test * improve test * update reassigned event comment * correct test * add assert check * improve tests for draws * add reveal vote invalid salt fails test * denounce slash inside reassign_juror_stakes * improve test readibility * rename periods to cycle_ends * add select jurors test * change randomness source in court tests * fix clippy * imrpove tests * remove cccount lookup in tests * improve test setup * add API tests, add missing unlockings * add full cycle court tests * remove invalid test * add missing WeightInfo * add inflation inside court * improve benchmarking and testing * add integrity_test * Update zrml/simple-disputes/src/mock.rs Co-authored-by: Harald Heckmann <[email protected]> * Update zrml/simple-disputes/src/mock.rs Co-authored-by: Harald Heckmann <[email protected]> * Update zrml/prediction-markets/src/lib.rs Co-authored-by: Harald Heckmann <[email protected]> * add doc string * add doc strings * Reduce settle_bonds LOC * cargo fmt * Update zrml/prediction-markets/src/migrations.rs Co-authored-by: Harald Heckmann <[email protected]> * Update zrml/prediction-markets/src/migrations.rs Co-authored-by: Harald Heckmann <[email protected]> * apply review suggestion * add GDItem integration * add delegations * improve code structure * fix benchmarks * optimize logic * add correct mdm benchmarking on_dispute * use on_dispute_weight inside api * improve mdm weight technique * add mdm weights to on_resolution * add tests for pm * modify migration logs, fix try-runtime * adjust tests for binary search * improve benchmarking * do small change * little benchmark fix * Update zrml/authorized/src/benchmarks.rs Co-authored-by: Harald Heckmann <[email protected]> * Update zrml/authorized/src/benchmarks.rs Co-authored-by: Harald Heckmann <[email protected]> * use result with weight struct * improve code * update benchmark and weights * improve dispute api weight system * test delegations for reassign * correct benchmarks and test * remove comment * add API benchmarks * update weights * use generic vote item instead of outcome report * update to court id and generic court * fix stuff and add documentation * add court readme, use new parameters * improve naming, weighting * Use accurate dispute weight instead of max * take random ranges without replacement * add start_global_dispute tests * add test * fix typo * switch get_random_number algo * integrate court and reject simple disputes * update start_global_dispute bench * fix clippy * use efficient draw without replacement algorithm * small edits * round to min juror stake, use other draw algo * use partial fisher yates algorithm * improve naming and comments * update changelog for devs * improve dispute api documentation * correct call filters * add copyright notice * remove is_outcome and is_binary * remove unnecessary "Court" prefix * update copyright notices * remove front end comment * Update zrml/court/README.md Co-authored-by: Malte Kliemann <[email protected]> * npx prettier court readme * improve style of terminology * update readme * remove unnecessary impl block * update comment * remove todo * make reward_pot package private * Update zrml/court/src/lib.rs Co-authored-by: Malte Kliemann <[email protected]> * update integrity test * improve join court doc * improve extrinsic documentation * update delegate doc * make some types package private * fix struct comment * update readme * update readme * remove commitment matcher * fix doc string * remove unnecessary error * improve import * improve test case * fix inflation misbehaviour * improve round timing structure * improve error names * fix get_valid_delegated_juror * remove wrong break * update weight for select jurors * allow rejoin after exit preparation * remove unnecessary apis * improve naming and docs * fix clippy * correct migrations * fix copyrights * fmt * fix clippy * fix copyrights * update changelog for devs * Update runtime/common/src/lib.rs Co-authored-by: Harald Heckmann <[email protected]> * Update zrml/court/src/lib.rs Co-authored-by: Harald Heckmann <[email protected]> * Update zrml/court/src/benchmarks.rs Co-authored-by: Harald Heckmann <[email protected]> * comment benchmark components * comment benchmark component * Update zrml/court/README.md Co-authored-by: Harald Heckmann <[email protected]> * add terminology for court * Update zrml/prediction-markets/src/benchmarks.rs Co-authored-by: Harald Heckmann <[email protected]> * restructure import * Update zrml/court/src/lib.rs Co-authored-by: Harald Heckmann <[email protected]> * Update zrml/court/src/lib.rs Co-authored-by: Harald Heckmann <[email protected]> * Update zrml/court/src/lib.rs Co-authored-by: Harald Heckmann <[email protected]> * use mul_floor and reduce indentation * safe guard inflation emission * use imbalance for minting * use saturated div * logging if inflation period mint too high * fix after merge * update changelog for devs * use imperative * fmt * Update zrml/court/src/lib.rs Co-authored-by: Harald Heckmann <[email protected]> * reduce court InflationPeriod for Battery Station * Update zrml/court/src/lib.rs Co-authored-by: Harald Heckmann <[email protected]> * fmt * fix tests * fix issue tokens without burn * remove unnecessary error return * Update Makefile * allow equal amount to previous stake --------- Co-authored-by: Malte Kliemann <[email protected]> Co-authored-by: Harald Heckmann <[email protected]> * activate court and GD on battery station * bump storage version of market commons * Update runtime/zeitgeist/src/lib.rs * Update runtime/zeitgeist/src/lib.rs * Revert "Reduce runtime test dependencies by half" This reverts commit fe589a5. * Update weight templates * Use header option for benchmarks Also format benchmark script and moves header file into HEADER_GPL3. * Update rust-toolchain * Satisfy clippy * Use patched wasm-builder for new rustc * Format * Update licenses --------- Co-authored-by: Harald Heckmann <[email protected]> Co-authored-by: Malte Kliemann <[email protected]>

Chralt98 added the s:review-needed The pull request requires reviews label Dec 15, 2022

Chralt98 requested review from vivekvpandya, sea212 and maltekliemann December 15, 2022 14:57

Chralt98 self-assigned this Dec 15, 2022

maltekliemann added this to the v0.3.8 milestone Dec 15, 2022

vivekvpandya reviewed Dec 16, 2022

View reviewed changes

zrml/global-disputes/src/lib.rs Show resolved Hide resolved

vivekvpandya reviewed Dec 16, 2022

View reviewed changes

zrml/global-disputes/src/lib.rs Show resolved Hide resolved

maltekliemann requested changes Dec 17, 2022

View reviewed changes

maltekliemann added s:revision-needed The pull requests must be revised and removed s:review-needed The pull request requires reviews labels Dec 17, 2022

Chralt98 added s:in-progress The pull requests is currently being worked on and removed s:revision-needed The pull requests must be revised labels Dec 19, 2022

Chralt98 changed the title ~~[Global Disputes] Fail for outcome mismatch in add_vote_outcome~~ [Global Disputes] Fix issues after first battery station live test Dec 20, 2022

Chralt98 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Jan 3, 2023

Chralt98 requested review from maltekliemann and vivekvpandya January 3, 2023 15:42

Chralt98 removed this from the v0.3.8 milestone Jan 5, 2023

Chralt98 added 3 commits August 22, 2023 20:08

fmt

6ec8c5d

fix tests

0d7a506

fix issue tokens without burn

459e9ff

Chralt98 added s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews labels Aug 23, 2023

Chralt98 added 2 commits August 23, 2023 10:48

remove unnecessary error return

3a33893

Merge branch 'chralt98-court-overhaul' into chralt98-fix-global-disputes

e2f5114

Chralt98 added s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews labels Aug 23, 2023

Chralt98 commented Aug 23, 2023

View reviewed changes

Update Makefile

30dc38f

maltekliemann approved these changes Aug 23, 2023

View reviewed changes

Chralt98 added 3 commits August 23, 2023 12:16

allow equal amount to previous stake

a04810b

Merge branch 'release-dispute-system' into chralt98-court-overhaul

7b399bb

Merge branch 'chralt98-court-overhaul' into chralt98-fix-global-disputes

b792304

sea212 approved these changes Aug 23, 2023

View reviewed changes

Base automatically changed from chralt98-court-overhaul to release-dispute-system August 23, 2023 14:06

mergify bot added s:revision-needed The pull requests must be revised and removed s:review-needed The pull request requires reviews labels Aug 23, 2023

Merge branch 'release-dispute-system' into chralt98-fix-global-disputes

72c03d0

Chralt98 added s:review-needed The pull request requires reviews s:accepted This pull request is ready for merge and removed s:revision-needed The pull requests must be revised s:review-needed The pull request requires reviews labels Aug 23, 2023

Chralt98 merged commit 6e27186 into release-dispute-system Aug 23, 2023
18 of 23 checks passed

Chralt98 deleted the chralt98-fix-global-disputes branch August 23, 2023 14:24

sea212 mentioned this pull request Aug 24, 2023

Implement production dispute system #1085

Merged

sea212 added this to the v0.4.0 milestone Sep 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Global Disputes] Fix issues after first battery station live test #912

[Global Disputes] Fix issues after first battery station live test #912

Chralt98 commented Dec 15, 2022 •

edited

Loading

maltekliemann left a comment

maltekliemann Dec 17, 2022

Chralt98 Dec 19, 2022

maltekliemann Dec 30, 2022

Chralt98 Jan 2, 2023

vivekvpandya Jan 24, 2023

Chralt98 Jan 24, 2023

maltekliemann Aug 23, 2023

Chralt98 Aug 23, 2023

maltekliemann Dec 17, 2022

Chralt98 Dec 19, 2022

maltekliemann Dec 30, 2022

Chralt98 Jan 4, 2023

maltekliemann commented Dec 18, 2022

Chralt98 commented Dec 19, 2022

Chralt98 commented Dec 20, 2022 •

edited

Loading

maltekliemann commented Dec 30, 2022

Chralt98 commented Jan 2, 2023

Chralt98 Aug 23, 2023 •

edited

Loading

Chralt98 Aug 23, 2023

sea212 Aug 23, 2023

Chralt98 Aug 23, 2023 •

edited

Loading

sea212 Aug 23, 2023

Chralt98 Aug 23, 2023

mergify bot commented Aug 23, 2023

	Self::update_winner(&market_id, &outcome, voting_outcome_fee);
	let possession =
	Some(Possession::Paid { owner: owner.clone(), fee: voting_outcome_fee });
	let outcome_info = OutcomeInfo { outcome_sum: voting_outcome_fee, possession };
	<Outcomes<T>>::insert(market_id, outcome.clone(), outcome_info);

	pallets.push(GlobalDisputesPalletId::get());

	if let Some(pallet_id) = frame_support::PalletId::try_from_sub_account::<u128>(ai) {
	return pallets.contains(&pallet_id.0);
	}

	for pallet_id in pallets {
	let pallet_acc: AccountId = pallet_id.into_account_truncating();

	if pallet_acc == *ai {
	return true;

	for i in 1..=o {
	let owner = account("winners_owner", i, 0);
	owners.push(owner);
	}
	let owners = BoundedVec::try_from(owners.clone()).unwrap();
	let winner_outcome = OutcomeReport::Scalar(0);

	let possession = Possession::Shared { owners };

[Global Disputes] Fix issues after first battery station live test #912

[Global Disputes] Fix issues after first battery station live test #912

Conversation

Chralt98 commented Dec 15, 2022 • edited Loading

maltekliemann left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maltekliemann commented Dec 18, 2022

Chralt98 commented Dec 19, 2022

Chralt98 commented Dec 20, 2022 • edited Loading

maltekliemann commented Dec 30, 2022

Chralt98 commented Jan 2, 2023

Chralt98 Aug 23, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Chralt98 Aug 23, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mergify bot commented Aug 23, 2023

Chralt98 commented Dec 15, 2022 •

edited

Loading

Chralt98 commented Dec 20, 2022 •

edited

Loading

Chralt98 Aug 23, 2023 •

edited

Loading

Chralt98 Aug 23, 2023 •

edited

Loading