Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[swaps] Check that user has enough pool tokens on withdraw #496

Merged
merged 5 commits into from
Mar 25, 2022
Merged

[swaps] Check that user has enough pool tokens on withdraw #496

merged 5 commits into from
Mar 25, 2022

Conversation

maltekliemann
Copy link
Member

@maltekliemann maltekliemann commented Mar 21, 2022 •
edited
Loading

This is similar, but not the same as issue 1 of the article linked in #485.

@maltekliemann maltekliemann added the s:in-progress The pull requests is currently being worked on label Mar 21, 2022
@maltekliemann
Fix test
eb70c4a 
Previously, in
ensure_which_operations_can_be_called_depending_on_the_pool_status,
the signer Alice didn't own any pool tokens, which now causes an error.
We now give Alice some pool shares, and we need to adjust the min
received tokens.
@maltekliemann
Fix tests
28216d4 
In `market_resolve_does_not_hold_liquidity_withdraw`, FRED needs to
withdraw, as he is the one holding pool tokens.
@maltekliemann
Test that exit is not allowed with no funds
ab9b442
@maltekliemann maltekliemann added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Mar 21, 2022
@maltekliemann maltekliemann mentioned this pull request Mar 22, 2022
Closed
15 tasks
sea212
sea212 approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@sea212 sea212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

zrml/swaps/src/lib.rs Outdated Show resolved Hide resolved
@maltekliemann @sea212
Make check more rustacean
f30fcef 
Co-authored-by: Harald Heckmann <[email protected]>
@maltekliemann maltekliemann merged commit 9d97326 into zeitgeistpm:main Mar 25, 2022
@sea212 sea212 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Mar 25, 2022
@sea212 sea212 added this to the v0.3.0 milestone Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sea212 sea212 sea212 approved these changes

Assignees
No one assigned
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@maltekliemann @sea212