Implement close markets early feature #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is now in conflicts. Could you fix it @Chralt98? 🙏 |
mergify
bot
added
s:revision-needed
Chralt98
added
s:in-progress
|
This pull request is now in conflicts. Could you fix it @Chralt98? 🙏 |
mergify
bot
added
s:revision-needed
Chralt98
added
s:in-progress
mergify
bot
added
s:revision-needed
Chralt98
added
the
i:transactions-changed ⚠️
sea212
reviewed
Oct 24, 2023
Co-authored-by: Harald Heckmann <[email protected]>
sea212
added
s:review-needed
|
This pull request is now in conflicts. Could you fix it @Chralt98? 🙏 |
mergify
bot
added
s:revision-needed
Chralt98
added
s:in-progress
mergify
bot
added
s:revision-needed
Chralt98
added
s:review-needed
Chralt98
added
s:review-needed
sea212
approved these changes
Oct 26, 2023
Chralt98
added
s:accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It allows the market creator to schedule an early market close. It allows the AC to schedule a fast-track early market close. Additionally the market creator's early market close can be disputed by anyone, who is willing to pay the bond (CloseDisputeBond) required. The schedule of the early market close can also be rejected by the AC.
What important points should reviewers know?
Is there something left for follow-up PRs?
The decision to close a market early should be done as decentralised as possible. That's why I suggest to use the court system for this decision-making in the future.
What alternative implementations were considered?
Are there relevant PRs or issues?
References