dynamically layout the Note and Result based on keyboard #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use flexbox to dynamically layout
- use KeyboardAvoidingView to adjust the height so that flexbox can
adjust according
- TODO: have more control with flexGrow/flexShrink
([reference](https://reactnative.dev/docs/flexbox#flex-basis-grow-and-shrink))
|
Hey @TDHTTTT, Thanks for picking this issue. I found some problems testing on an iPhone device:
RPReplay_Final1661395845.MP4What devices did you have a chance to test with? |
pages/Editor.js
Outdated
| @@ -417,10 +420,11 @@ const styles = StyleSheet.create({ | |||
| borderTopLeftRadius: 24, | |||
| fontFamily: "iA Writer Quattro", | |||
| width: "100%", | |||
| position: "absolute", | |||
| height: 165, | |||
| minheight: 165, | |||
|
Hey @zehfernandes thanks for the reply! I tested with my iPhone XS MAX. I will take a look at the issues and try to fix them over the weekend. |
|
@zehfernandes I think I fixed the onDrag keyboard dismiss. However, the size of the result box is a bit tricky to debug so I don't have a good solution now. Also, interestingly, the issue doesn't seem to appear in simulator. Please see the video attached which is recorded on a iPhone 13 mini simulator. Simulator.Screen.Recording.-.iPhone.13.mini.-.2022-08-27.at.17.31.34.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adjust according
(reference)