Modernize project #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had dedicated code which replicated setuptools' "development mode"[^1] in that we could import from a not installed package. This not only complicated the code for no good reason, but also tripped up linting tools. This patch removes these workarounds. [^1]: https://setuptools.pypa.io/en/latest/userguide/development_mode.html
We would previously included code to deal with optional dependencies in an ad hoc way in the code. Since we are a proper package which already has requirements this is not really needded. Instead simply require these dependencies with this patch.
bbannier
force-pushed
the
topic/bbannier/modernize-project
branch
from
5a971e7
to
ebc299a
Compare
bbannier
force-pushed
the
topic/bbannier/modernize-project
branch
from
ebc299a
to
e430537
Compare
timwoj
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modernizes the project and moves linting to ruff like which we already use in many other Zeek Python projects.