Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btest-bg-run-helper: Ignore SIGTERM to self during cleanup #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

btest-bg-run-helper: Ignore SIGTERM to self during cleanup #105

wants to merge 1 commit into from

Conversation

awelzel
Copy link
Contributor

@awelzel awelzel commented Oct 2, 2024

The kill 0 invocation would kill the btest-bg-run-helper itself, causing the subsequent logic to not be executed, resulting in runaway processes on the system.

@awelzel
btest-bg-run-helper: Ignore SIGTERM to self during cleanup
06ab036 
The kill 0 invocation would kill the btest-bg-run-helper itself,
causing the subsequent logic to not be executed, resulting in
runaway processes on the system.
@awelzel
Copy link
Contributor Author

awelzel commented Oct 2, 2024

I was tempted to add a -SIGKILL for the process group at the end of the cleanup, but IIUC in the worst case this may SIGKILL unrelated processes because btest-setsid ignores setsid() error situations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@awelzel