Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supermaven completions behave strangely when writing over them #19716

Open
1 task done
alexkirsz opened this issue Oct 25, 2024 · 0 comments
Open
1 task done

Supermaven completions behave strangely when writing over them #19716

alexkirsz opened this issue Oct 25, 2024 · 0 comments
Labels
admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue

Comments

@alexkirsz
Copy link

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

In Zed's Supermaven completion, if you start writing over a suggested completion in a way that doesn't match the completion, the completion isn't properly discarded and replaced. This causes weird behavior where partial completions stay on screen, even though they no longer make sense/would be invalid.

For instance:

Screen.Recording.2024-10-25.at.09.03.41.mov

Compare this to VS Code's implementation, which:

  1. Properly discards/replaces suggestions as they are invalidated; and
  2. When a suggestion cannot be reconciled with the current line, it is proposed at the very end of the line instead.
Screen.Recording.2024-10-25.at.09.05.53.mov

Environment

Zed: v0.158.2 (Zed)
OS: macOS 14.6.1
Memory: 32 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log
@alexkirsz alexkirsz added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue
Projects
None yet
Development

No branches or pull requests

1 participant