Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(cmake): correctly find libarchive on Apple-M series #1607

Closed
wants to merge 1 commit into from
Closed

build(cmake): correctly find libarchive on Apple-M series #1607

wants to merge 1 commit into from

Conversation

zchrissirhcz
Copy link
Contributor

For the issue #1602

@zchrissirhcz
Copy link
Contributor Author

I locally use a mac-mini with brew install libarchive, and this PR can fix build.

@alt-romes Can you please try it locally if possible?

@zchrissirhcz
Copy link
Contributor Author

@trollixx Could you please review this PR when you have a moment?

@zchrissirhcz zchrissirhcz marked this pull request as draft April 1, 2024 15:47
@zchrissirhcz zchrissirhcz marked this pull request as ready for review April 2, 2024 00:47
@zchrissirhcz zchrissirhcz closed this by deleting the head repository May 13, 2024
@trollixx
Copy link
Member

@zchrissirhcz sorry I've been quite busy lately, was there an issue with the approach you proposed?

@zchrissirhcz zchrissirhcz mentioned this pull request May 19, 2024
Merged
@zchrissirhcz
Copy link
Contributor Author

@trollixx The approach I proposed works. I sometime delete not-that-active forked repos.
Now re-forked and re-PRed in #1621.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trollixx trollixx trollixx left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zchrissirhcz @trollixx