Skip to content

Apply suggestions from code review

Codecov / codecov/project failed Mar 6, 2024 in 1s

64.00% (-0.34%) compared to 0c12f31

View this Pull Request on Codecov

64.00% (-0.34%) compared to 0c12f31

Details

Codecov Report

Attention: Patch coverage is 64.89676% with 119 lines in your changes are missing coverage. Please review.

Project coverage is 64.00%. Comparing base (0c12f31) to head (f2f8af6).

❗ Current head f2f8af6 differs from pull request most recent head eaabc0f. Consider uploading reports for the commit eaabc0f to get more accurate results

Files Patch % Lines
components/zcash_protocol/src/value.rs 66.66% 46 Missing ⚠️
zcash_keys/src/keys.rs 24.24% 25 Missing ⚠️
components/zcash_protocol/src/consensus.rs 75.40% 15 Missing ⚠️
zcash_client_sqlite/src/wallet/init.rs 0.00% 7 Missing ⚠️
...src/wallet/init/migrations/receiving_key_scopes.rs 45.45% 6 Missing ⚠️
components/zcash_protocol/src/lib.rs 0.00% 4 Missing ⚠️
zcash_client_sqlite/src/error.rs 0.00% 4 Missing ⚠️
zcash_keys/src/address.rs 66.66% 4 Missing ⚠️
components/zcash_address/src/encoding.rs 90.90% 2 Missing ⚠️
zcash_client_backend/src/fees/sapling.rs 0.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1142      +/-   ##
==========================================
- Coverage   64.33%   64.00%   -0.34%     
==========================================
  Files         115      115              
  Lines       11872    11899      +27     
==========================================
- Hits         7638     7616      -22     
- Misses       4234     4283      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.