Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency updates #1392

Merged
merged 3 commits into from
May 24, 2024
Merged

Dependency updates #1392

merged 3 commits into from
May 24, 2024

Conversation

daira
Copy link
Contributor

@daira daira commented May 14, 2024 •
edited
Loading

Update dependencies and audits, and bump MSRV to 1.66.

@daira daira added the dependencies Pull requests that update a dependency file label May 14, 2024
@daira daira requested a review from str4d May 14, 2024 11:46
@daira
Copy link
Contributor Author

daira commented May 14, 2024 •
edited
Loading

Audit updates are not complete yet.

@daira daira force-pushed the cargo-update-2024-05 branch from 4d58ae0 to f74e0f9 Compare May 15, 2024 11:22
daira
daira commented May 15, 2024
View reviewed changes
Cargo.lock Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented May 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.13%. Comparing base (0b350c1) to head (851e203).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1392   +/-   ##
=======================================
  Coverage   63.13%   63.13%           
=======================================
  Files         126      126           
  Lines       14720    14720           
=======================================
  Hits         9293     9293           
  Misses       5427     5427

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daira daira force-pushed the cargo-update-2024-05 branch 6 times, most recently from bf223c1 to 51d0dbf Compare May 16, 2024 03:37
@daira daira marked this pull request as ready for review May 16, 2024 03:40
@daira daira force-pushed the cargo-update-2024-05 branch from 51d0dbf to dbe0e4d Compare May 20, 2024 12:27
daira added 2 commits May 20, 2024 13:35
@daira
Update dependencies (including to avoid a vulnerability warning for a…
aa77be8 
…tty), bump MSRV to 1.66,

and fix new clippy lints for MSRV 1.66.

* tonic 0.10 -> 0.11
* tonic-build 0.10 -> 0.11
* cargo update
* cargo update -p [email protected] --precise 0.5.5
* cargo update -p [email protected] --precise 0.12.3
* cargo update -p [email protected] --precise 0.12.3
* cargo update -p [email protected] --precise 0.12.3
* cargo update -p [email protected] --precise 0.12.3
* cargo update -p [email protected] --precise 2.2.1

(The precise updates avoid a further MSRV bump to 1.70.)

Remaining duplicates are currently unavoidable.

Signed-off-by: Daira-Emma Hopwood <[email protected]>
@daira
Add audits and bump some exemptions.
39a6b2b 
Signed-off-by: Daira-Emma Hopwood <[email protected]>
@daira daira force-pushed the cargo-update-2024-05 branch from dbe0e4d to 39a6b2b Compare May 20, 2024 12:36
@str4d str4d mentioned this pull request May 23, 2024
Merged
str4d
str4d previously approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK after changelog fixes.

Cargo.toml
Comment on lines +99 to +100
tonic = { version = "0.11", default-features = false }
tonic-build = { version = "0.11", default-features = false }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tonic 0.11 bumps MSRV to 1.70. That also happens to be the next MSRV I wanted to target for zcash_primitives and its downstream crates (I'm more cautious about bumping MSRV for crates like pasta_curves, but for the crates in this workspace 1.70 should be fine). We were blocked from doing so by zcashd being stuck on 1.69, but that was finally fixed last month in zcash/zcash#6879.

I note that in the first commit you avoided certain other dependency updates that would require 1.70; we can upgrade those now. Given that tonic 0.11 only forces the case for zcash_client_backend with the relevant feature flag enabled, I'm fine with merging this PR as-is, and then landing a follow-up PR that uniformly bumps MSRV to 1.70.

components/equihash/CHANGELOG.md Outdated Show resolved Hide resolved
components/f4jumble/CHANGELOG.md Outdated Show resolved Hide resolved
components/zcash_address/CHANGELOG.md Outdated Show resolved Hide resolved
components/zcash_encoding/CHANGELOG.md Outdated Show resolved Hide resolved
components/zcash_protocol/CHANGELOG.md Show resolved Hide resolved
components/zip321/CHANGELOG.md Show resolved Hide resolved
zcash_client_backend/CHANGELOG.md Outdated Show resolved Hide resolved
supply-chain/audits.toml
A comment in get_sni_extension asks whether the behaviour of parsing an IPv4 or IPv6 address
in a host_name field of a server_name extension, but then ignoring the extension (because
'Literal IPv4 and IPv6 addresses are not permitted in \"HostName\"'), as the server, is
compliant with RFC 6066. As an original author of RFC 3546 which has very similar wording,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

str4d
str4d approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-utACK 851e203

@str4d str4d merged commit 976a4d2 into main May 24, 2024
27 of 28 checks passed
@str4d str4d deleted the cargo-update-2024-05 branch May 24, 2024 15:56
@daira
Copy link
Contributor Author

daira commented May 28, 2024

Post-hoc ACK 851e203.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@str4d str4d str4d approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daira @str4d