Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash_client_sqlite: Use named column accessors for to_spendable_note #1339

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

nuttycom
Copy link
Contributor

@nuttycom nuttycom commented Apr 1, 2024

No description provided.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 47.36842% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 63.81%. Comparing base (cc9ea39) to head (bdd0990).

Files Patch % Lines
zcash_client_sqlite/src/wallet/orchard.rs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1339   +/-   ##
=======================================
  Coverage   63.80%   63.81%           
=======================================
  Files         123      123           
  Lines       14269    14267    -2     
=======================================
- Hits         9105     9104    -1     
+ Misses       5164     5163    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK bdd0990

@str4d str4d merged commit eff1a2b into zcash:main Apr 1, 2024
24 of 25 checks passed
@nuttycom nuttycom deleted the use_named_column_accessors branch April 1, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants