zcash_client_sqlite: Disallow selection of dust notes. #1312
Conversation
At present, we don't take builder padding rules into account in the determination of whether or not we can include spends of dust notes in grace actions. It's too complex to attempt a complete fix for Zashi 1.0, but we can have a tolerable workaround for launch by just never selecting dust-valued notes. This is a temporary solution; opened #1316 to track the resolution.
nuttycom
force-pushed
the
avoid_dust_note_selection
branch
from
d6f841d to
0d8f569
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1312 +/- ##
==========================================
- Coverage 63.44% 63.35% -0.09%
==========================================
Files 121 121
Lines 14142 14143 +1
==========================================
- Hits 8972 8960 -12
- Misses 5170 5183 +13 ☔ View full report in Codecov by Sentry. |
| @@ -597,6 +597,7 @@ pub(crate) mod tests { | |||
|
|
|||
| #[test] | |||
| #[ignore] // FIXME: #1316 This requires support for dust outputs. | |||
| #[cfg(not(feature = "expensive-tests"))] | |||
There was a problem hiding this comment.
Why are these cfg(not(...)) instead of just cfg(...)?
There was a problem hiding this comment.
So, it's annoying. CI uses the -- --ignored flag to run just the ignored tests. So I want this test to actually be ignored, so I made the slow tests CI workflow use the expensive-tests feature, and then I opt this out of the slow tester by adding this cfg attr.
At present, we don't take builder padding rules into account in the determination of whether or not we can include spends of dust notes in grace actions. It's too complex to attempt a complete fix for Zashi 1.0, but we can have a tolerable workaround for launch by just never selecting dust-valued notes.