zcash_keys: Remove HdSeedFingerprint as it duplicates zip32::fingerprint::SeedFingerprint'
#1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuttycom
force-pushed
the
use_zip32_seed_fingerprint
branch
from
7197737 to
bec66f0
Compare
str4d
previously approved these changes
Mar 14, 2024
…rint::SeedFingerprint`
nuttycom
force-pushed
the
use_zip32_seed_fingerprint
branch
from
bec66f0 to
cc990b6
Compare
str4d
approved these changes
Mar 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1274 +/- ##
==========================================
- Coverage 63.50% 63.45% -0.05%
==========================================
Files 121 121
Lines 13711 13702 -9
==========================================
- Hits 8707 8695 -12
- Misses 5004 5007 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.