Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIs for mobile SDKs #1266

Merged
merged 2 commits into from
Mar 13, 2024
Merged

APIs for mobile SDKs #1266

merged 2 commits into from
Mar 13, 2024

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Mar 13, 2024

This PR only adds one of the needed APIs for the mobile SDKs; due to also refactoring the traits, I decided to split the other changes (which are themselves non-trivial) to a follow-on PR.

@str4d str4d added this to the Librustzcash Zashi 1.0 milestone Mar 13, 2024
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, essentially move-only.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 31.14754% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 63.55%. Comparing base (b3d06ba) to head (634ebf5).

Files Patch % Lines
zcash_client_backend/src/data_api.rs 0.00% 24 Missing ⚠️
zcash_client_sqlite/src/lib.rs 61.29% 12 Missing ⚠️
zcash_client_backend/src/proto.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1266      +/-   ##
==========================================
- Coverage   63.57%   63.55%   -0.03%     
==========================================
  Files         121      121              
  Lines       13646    13652       +6     
==========================================
  Hits         8676     8676              
- Misses       4970     4976       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@str4d str4d merged commit 05259ef into main Mar 13, 2024
21 of 26 checks passed
@str4d str4d deleted the apis-for-mobile-sdks branch March 13, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants