zcash_client_sqlite: Run single-shielded-pool tests on Orchard #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables us to activate Sapling and NU5 at the same height, to simplify reuse of test logic between Sapling and Orchard. As a side-effect, `zcash_extensions` is removed from the workspace because it enables the `zfuture` feature flag unconditionally, which breaks workspace-level builds because this causes the `zfuture` feature flag on `zcash_protocol` to be enabled without the corresponding feature flag on `zcash_client_sqlite` being enabled. We will fix this by moving from feature flags to config flags for unstable features.
This makes individual instances of `TestState` deterministic, which helps with debugging.
str4d
force-pushed
the
zcs-orchard-testing
branch
from
e9745d1 to
75c5f31
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1250 +/- ##
==========================================
- Coverage 64.91% 63.53% -1.39%
==========================================
Files 117 117
Lines 12818 12645 -173
==========================================
- Hits 8321 8034 -287
- Misses 4497 4611 +114 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost all of these tests currently fail, as expected.
This PR also makes some fixes and improvements to the test harness, that arose from debugging the new Orchard code.