Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash_client_sqlite: Track Orchard commitment tree sizes in TestState #1248

Merged
merged 3 commits into from
Mar 9, 2024

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Mar 9, 2024

No description provided.

@str4d str4d added this to the Librustzcash Zashi 1.0 milestone Mar 9, 2024
@str4d str4d requested a review from nuttycom March 9, 2024 17:52
nuttycom
nuttycom previously approved these changes Mar 9, 2024
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK ef5dba4

Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 92.59259% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 64.91%. Comparing base (39c7503) to head (0891b5f).

Files Patch % Lines
zcash_client_sqlite/src/testing.rs 92.59% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1248      +/-   ##
==========================================
+ Coverage   64.88%   64.91%   +0.03%     
==========================================
  Files         117      117              
  Lines       12801    12818      +17     
==========================================
+ Hits         8306     8321      +15     
- Misses       4495     4497       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@str4d str4d force-pushed the zcs-test-state-orchard-tree branch from ef5dba4 to 0891b5f Compare March 9, 2024 18:22
@str4d
Copy link
Contributor Author

str4d commented Mar 9, 2024

Force-pushed to fix clippy lints and test failures.

Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK 0891b5f

@str4d str4d merged commit 58f46e4 into main Mar 9, 2024
25 checks passed
@str4d str4d deleted the zcs-test-state-orchard-tree branch March 9, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants