Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zcash_client_sqlite: Add Orchard support to test harness #1233

Merged
merged 7 commits into from
Mar 8, 2024
Merged

zcash_client_sqlite: Add Orchard support to test harness #1233

merged 7 commits into from
Mar 8, 2024

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Mar 8, 2024

No description provided.

@str4d str4d requested a review from nuttycom March 8, 2024 01:10
@str4d str4d force-pushed the test-harness-orchard-fvk branch from 4616833 to 495cae8 Compare March 8, 2024 01:39
@codecov Codecov
Copy link

codecov bot commented Mar 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.58%. Comparing base (8130359) to head (c8d03f6).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1233      +/-   ##
==========================================
- Coverage   63.89%   63.58%   -0.32%     
==========================================
  Files         115      115              
  Lines       11930    12008      +78     
==========================================
+ Hits         7623     7635      +12     
- Misses       4307     4373      +66

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nuttycom
nuttycom requested changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@nuttycom nuttycom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused by the add_compact_action function - is that adding an Orchard action, or a logical action?

Also there are Clippy errors.

zcash_client_sqlite/src/testing.rs Show resolved Hide resolved
zcash_client_sqlite/src/testing.rs Show resolved Hide resolved
zcash_client_sqlite/src/testing.rs Outdated Show resolved Hide resolved
zcash_client_sqlite/src/testing.rs Show resolved Hide resolved
@str4d str4d force-pushed the test-harness-orchard-fvk branch from 495cae8 to cc90c4c Compare March 8, 2024 13:29
@str4d
Copy link
Contributor Author

str4d commented Mar 8, 2024

Force-pushed to silence Clippy lints, and rename TestFvk methods for clarity.

@str4d str4d changed the title zcash_client_sqlite: Add Orchard FVK support to test harness zcash_client_sqlite: Add Orchard support to test harness Mar 8, 2024
@str4d str4d force-pushed the test-harness-orchard-fvk branch from ca16cd7 to c8d03f6 Compare March 8, 2024 14:40
nuttycom
nuttycom approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK c8d03f6

@nuttycom nuttycom merged commit 6345053 into main Mar 8, 2024
46 of 47 checks passed
@nuttycom nuttycom deleted the test-harness-orchard-fvk branch March 8, 2024 18:37
@nuttycom nuttycom mentioned this pull request Mar 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuttycom nuttycom nuttycom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@str4d @nuttycom