zcash_client_backend: Add Orchard frontier to AccountBirthday
#1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuttycom
changed the title
AccountBirthdayAccountBirthday
nuttycom
force-pushed
the
wallet/orchard_account_birthday
branch
from
24bd755 to
4532520
Compare
daira
reviewed
Mar 7, 2024
Comment on lines
963
to
+966
| sapling_frontier: Frontier<sapling::Node, { sapling::NOTE_COMMITMENT_TREE_DEPTH }>, | ||
| #[cfg(feature = "orchard")] | ||
| orchard_frontier: | ||
| Frontier<orchard::tree::MerkleHashOrchard, { orchard::NOTE_COMMITMENT_TREE_DEPTH as u8 }>, |
There was a problem hiding this comment.
Non-blocking suggestion: add SaplingFrontier and OrchardFrontier type aliases.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1232 +/- ##
==========================================
- Coverage 63.89% 63.89% -0.01%
==========================================
Files 115 115
Lines 11930 11934 +4
==========================================
+ Hits 7623 7625 +2
- Misses 4307 4309 +2 ☔ View full report in Codecov by Sentry. |
str4d
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.