Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out protocol constants and value types into a zcash_protocol crate. #1142

Merged
merged 18 commits into from
Mar 6, 2024

Add missing CHANGELOG entries.

8955cfc
Select commit
Loading
Failed to load commit list.
Merged

Factor out protocol constants and value types into a zcash_protocol crate. #1142

Add missing CHANGELOG entries.
8955cfc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Mar 6, 2024 in 0s

64.01% (-0.33%) compared to 0c12f31

View this Pull Request on Codecov

64.01% (-0.33%) compared to 0c12f31

Details

Codecov Report

Attention: Patch coverage is 65.17857% with 117 lines in your changes are missing coverage. Please review.

Project coverage is 64.01%. Comparing base (0c12f31) to head (8955cfc).

❗ Current head 8955cfc differs from pull request most recent head eaabc0f. Consider uploading reports for the commit eaabc0f to get more accurate results

Files Patch % Lines
components/zcash_protocol/src/value.rs 67.40% 44 Missing ⚠️
zcash_keys/src/keys.rs 24.24% 25 Missing ⚠️
components/zcash_protocol/src/consensus.rs 75.40% 15 Missing ⚠️
zcash_client_sqlite/src/wallet/init.rs 0.00% 7 Missing ⚠️
...src/wallet/init/migrations/receiving_key_scopes.rs 45.45% 6 Missing ⚠️
components/zcash_protocol/src/lib.rs 0.00% 4 Missing ⚠️
zcash_client_sqlite/src/error.rs 0.00% 4 Missing ⚠️
zcash_keys/src/address.rs 66.66% 4 Missing ⚠️
components/zcash_address/src/encoding.rs 90.90% 2 Missing ⚠️
zcash_client_backend/src/fees/sapling.rs 0.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1142      +/-   ##
==========================================
- Coverage   64.33%   64.01%   -0.33%     
==========================================
  Files         115      115              
  Lines       11872    11896      +24     
==========================================
- Hits         7638     7615      -23     
- Misses       4234     4281      +47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov