recovery shell: print zerrors since the last command was executed #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahesford
reviewed
Dec 18, 2023
zdykstra
force-pushed
the
error-error-on-the-wall
branch
from
c188dc8
to
3b3394e
Compare
ahesford
approved these changes
Dec 18, 2023
zdykstra
force-pushed
the
error-error-on-the-wall
branch
from
3b3394e
to
7db746b
Compare
zdykstra
force-pushed
the
error-error-on-the-wall
branch
from
7db746b
to
6fb828d
Compare
|
This is good enough for now. I'll think a bit more about how I want to refine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not super happy with how
print_kmsg_logsis shaking out, but there's only so much time I'm willing to spend chasing elegance.This is modestly tested, and could likely use further refinement after people play with it.