zfsbootmenu-core: disable block cloning for R/W pools #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block cloning in ZFS 2.2.0 is dangerous. Until it stabilizes, we should disable it if the tuneable to do so is available when a pool is set read/write.
See openzfs/zfs#15529 for more details.
I don't think we need to expose this as a toggleable option. This feature should be simple and not plumbed very deeply, on the hope that it's just a short-term patch for an unlikely source of problems for people. If users really care, they can turn it back on before doing whatever it is they're going to do in the recovery shell.