bin/generate-zbm: use objcopy procedure from mkinitcpio #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The global state bothers me. What about making these functions take as inputs the current offset as well as the alignment? |
|
It shouldn't be too bad to pass those refs around. I'll make that change tomorrow. |
|
I hear Perl supports classes now. 🤔 |
😆 |
ahesford
approved these changes
Oct 24, 2023
zdykstra
force-pushed
the
lawd-i-am-dewy
branch
from
f6177da
to
9502718
Compare
Newer versions of the EFI stub provided by systemd-boot are incompatible with the method used by generate-zbm to add sections to the output bundle. mkinitcpio uses a process that evaluates the sizes of each component being combined into the EFI bundle and adjusts their section VMA accordingly. This has been tested with the latest systemd-boot EFI stub and the most recent Gummiboot EFI stub.
zdykstra
force-pushed
the
lawd-i-am-dewy
branch
from
9502718
to
09a8ee7
Compare
|
Any chance we could get a new release published with this? |
|
Yes, there will likely be a release tagged tonight. If you'd like to test the patched Edit: That is, test prior to a release being tagged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a direct clone of the process/steps used by
mkinitcpio. It's been tested locally with the Gummiboot stub and the most recent stub available on Arch; both are able to boot a test VM. Pending further review, I'll clean up the commits and add a larger degree of comments on what is happening. There's been minimal error handling added to this.Comments/testing/nits welcome.
Closes #503