zfsbootmenu: remove legacy root= usage/design #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZFSBootMenu has danced around `$root` for a few years now, as a holdover from very early design decisions picked up from Dracut. We don't actually _need_ to tie ourselves to that variable - and in fact, a lot of the early startup process can be simplified by no longer trying to stuff so much logic into it. To that end, the legacy but undocumented support for `root=zfsbootmenu:POOL=pool` has been completely removed. `root` on the ZBM KCL is no longer honored. `zbm.prefer` with the documented syntax is now the only way to tell ZFSBootMenu which pool should be preferentially used in the boot process. Accordingly, the global `zbm_prefer_pool` variable is now set when a pool should be preferred, and the accompanying `zbm_require_pool` variable is used to indicate how firm that pool requirement is. One quirk of this is that a pool name of `zfsbootmenu` can now actually be a value that `zbm.prefer` will respect/honor.
zdykstra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZFSBootMenu has danced around
$rootfor a few years now, as a holdover from very early design decisions picked up from Dracut. We don't actually need to tie ourselves to that variable - and in fact, a lot of the early startup process can be simplified by no longer trying to stuff so much logic into it.To that end, the legacy but undocumented support for
root=zfsbootmenu:POOL=poolhas been completely removed.rooton the ZBM KCL is no longer honored.zbm.preferwith the documented syntax is now the only way to tell ZFSBootMenu which pool should be preferentially used in the boot process. Accordingly, the globalzbm_prefer_poolvariable is now set when a pool should be preferred, and the accompanyingzbm_require_poolvariable is used to indicate how firm that pool requirement is. One quirk of this is that a pool name ofzfsbootmenucan now actually be a value thatzbm.preferwill respect/honor.