Introducing load_key hook in zfsbootmenu/lib/zfsbootmenu-core.sh #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahesford
requested changes
Jul 18, 2023
ahesford
requested changes
Jul 19, 2023
There was a problem hiding this comment.
You really shouldn't be doing these edits from the GitHub UI. You need to:
- Drop the edits to
contrib/README.md - Restore
README.mdto its original state. Your latest commit deleted the entire file. - Add a section to
docs/man/zfsbootmenu.7.rst, between thezfsbootmenu_setupandzfsbootmenu_teardownsections of the "Options for dracut" block, fully describing the hooks. - Squash all of these commits down to one.
zdykstra
requested changes
Jul 19, 2023
|
Ok, I made all the changes you proposed.
…_____
From: Andrew J. Hesford ***@***.***
Sent: Wednesday, July 19, 2023 5:11 PM
To: zbm-dev/zfsbootmenu
Cc: rdmitry0911; Author
Subject: Re: [zbm-dev/zfsbootmenu] Introducing load_key hook in
zfsbootmenu/lib/zfsbootmenu-core.sh (PR #452)
@ahesford requested changes on this pull request.
You really shouldn't be doing these edits from the GitHub UI. You need to:
* Drop the edits to contrib/README.md
* Restore README.md to its original state. Your latest commit deleted
the entire file.
* Add a section to docs/man/zfsbootmenu.7.rst, between the
zfsbootmenu_setup and zfsbootmenu_teardown sections of the "Options for
dracut" block, fully describing the hooks.
* Squash all of these commits down to one.
-
Reply to this email directly, view
<#452 (review)
1> it on GitHub, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG6CLNKPTOZVQCLFBC2NLKLXQ
7MG7ANCNFSM6AAAAAA2OHKL5Q> .
You are receiving this because you authored the thread.
<https://github.com/notifications/beacon/AG6CLNKGF3BFGCUBZNJG5CLXQ7MG7A5CNFS
M6AAAAAA2OHKL5SWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3T
UL5UWJTS3TWUF6.gif> Message ID:
***@***.***>
|
ahesford
requested changes
Jul 20, 2023
ahesford
reviewed
Jul 20, 2023
Provided a function for automatic unlocking of encrypted zfs pool using clevis and pcr_ids 1,4,5,7,9 of tpm2 module Update zfsbootmenu-core.sh Update zbm-builder.sh Update zfsbootmenu Update module-setup.sh for load_key hook Update mkinitcpio.conf to include load_key hook Update mkinitcpio.conf to include load_key hook Update container-building.rst to include load_key hook Update container-building.rst to include load_key hook Update zfsbootmenu-core.sh to include load_key hook Update zfsbootmenu/lib/zfsbootmenu-core.sh Co-authored-by: Andrew J. Hesford <[email protected]> Update zfsbootmenu/lib/zfsbootmenu-core.sh Co-authored-by: Andrew J. Hesford <[email protected]> Update etc/zfsbootmenu/mkinitcpio.conf Co-authored-by: Andrew J. Hesford <[email protected]> Update etc/zfsbootmenu/mkinitcpio.conf Co-authored-by: Andrew J. Hesford <[email protected]> Update zfsbootmenu-core.sh Update docs/guides/general/container-building.rst Co-authored-by: Andrew J. Hesford <[email protected]> Update module-setup.sh Update etc/zbm-builder/mkinitcpio.conf Co-authored-by: Andrew J. Hesford <[email protected]> Update etc/zfsbootmenu/mkinitcpio.conf Co-authored-by: Andrew J. Hesford <[email protected]> Update zbm-builder.sh Co-authored-by: Andrew J. Hesford <[email protected]> Update zfsbootmenu
* Add ca-certs to recovery image, so cURL can connect over HTTPS * Add sgdisk to recovery image * Add zbm-kcl / zbm-kcl.8 documentation to release and recovery images Closes zbm-dev#400
Closes: zbm-dev#427. Update zfsbootmenu-core.sh Update mkinitcpio.conf Update zfsbootmenu-core.sh Update docs/man/zfsbootmenu.7.rst Co-authored-by: Andrew J. Hesford <[email protected]> Update docs/man/zfsbootmenu.7.rst Co-authored-by: Andrew J. Hesford <[email protected]>
|
There should be a single commit in this PR. You've added previous commits to this. |
|
Feel free to re-open this PR once the acceptance criteria have been met. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hook placeholder for scripts to run just before loading key for a dataset. It can be used for example for automatic dataset unlocking using clevis or for some other purposes. The only argument provided to the hook is dataset name
As a proof of concept a load_key_clevis_hook.sh script is included in contrib directory