Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): replace local toCubeShape with barnard59-cube #1515

Merged
merged 6 commits into from
May 23, 2024

Conversation

tpluscode
Copy link
Collaborator

@tpluscode tpluscode commented May 16, 2024

  • removed the toCubeShape copy
  • patched rdf-parser-csvw
  • adjust tests

@tpluscode tpluscode requested a review from giacomociti May 16, 2024 11:39
Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: 94c34c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-creator/cli Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.58%. Comparing base (8dcb7ec) to head (94c34c2).

Files Patch % Lines
cli/lib/cube.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           b59-up    #1515      +/-   ##
==========================================
+ Coverage   71.04%   73.58%   +2.53%     
==========================================
  Files         223      219       -4     
  Lines       15009    14729     -280     
  Branches      806      839      +33     
==========================================
+ Hits        10663    10838     +175     
+ Misses       4337     3882     -455     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tpluscode
Copy link
Collaborator Author

@giacomociti I removed one last failing test for the case of min/max + IRI dimension. Thought it did not make sense to replicate that test from b59 as it ws getting a little awkward

Base automatically changed from b59-up to master May 23, 2024 08:41
@tpluscode tpluscode merged commit a7c3681 into master May 23, 2024
19 checks passed
@tpluscode tpluscode deleted the to-cube-shape branch May 23, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants