Use cubelink shapes #1471
Use cubelink shapes #1471
Conversation
🦋 Changeset detectedLatest commit: 2fbd704 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1471 +/- ##
==========================================
+ Coverage 80.35% 80.36% +0.01%
==========================================
Files 198 199 +1
Lines 13665 13676 +11
Branches 828 829 +1
==========================================
+ Hits 10980 10991 +11
Misses 2676 2676
Partials 9 9 ☔ View full report in Codecov by Sentry. |
cli/shapes.ttl
Outdated
| @@ -25,7 +25,7 @@ base <https://cube-creator.zazuko.com/shape#> | |||
| sh:message "cube:Cube needs at least one cube:ObservationSet" ; | |||
| ] , [ | |||
| sh:path cube:observationConstraint ; | |||
| sh:node <ObservationConstraintShape> ; | |||
| sh:node <http://example.org/ObservationConstraintShape> ; # from cube.link | |||
There was a problem hiding this comment.
Ah, did not see that coming. Maybe it's gonna be a little nicer to merge zazuko/cube-link#107 and replace example.org
There was a problem hiding this comment.
v0.1.0 of cube-link has been published, which removes example.org
cli/pipelines/publish.ttl
Outdated
| <#shapeURLs> a :Step ; | ||
| code:implementedBy [ | ||
| a code:EcmaScriptModule ; | ||
| code:link <node:stream#Readable.from> ; | ||
| ] ; | ||
| code:arguments ( | ||
| """[ | ||
| 'https://cube.link/v0.0.5/shape/standalone-constraint-constraint', | ||
| // 'https://cube.link/v0.0.5/shape/datacatalog-constraint', | ||
| ]"""^^code:EcmaScript | ||
| ) | ||
| . |
There was a problem hiding this comment.
Fancy! Using Readable.from is a neat trick. I have to remember that.
It's a shame it takes the first argument and not a variadic argument
cli/shapes.ttl
Outdated
| @@ -25,7 +25,7 @@ base <https://cube-creator.zazuko.com/shape#> | |||
| sh:message "cube:Cube needs at least one cube:ObservationSet" ; | |||
| ] , [ | |||
| sh:path cube:observationConstraint ; | |||
| sh:node <ObservationConstraintShape> ; | |||
| sh:node <http://example.org/ObservationConstraintShape> ; # from cube.link | |||
There was a problem hiding this comment.
v0.1.0 of cube-link has been published, which removes example.org
|
@giacomociti great 👍️ |
No description provided.