Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page for Zarr implementations #85

Merged

Conversation

MSanKeys963
Copy link
Member

Linking this from #80.

Added a new page for the Zarr implementations. After merging this PR, it can be accessed at https://zarr.dev/implementations.

Thanks, @joshmoore, for helping me with this.

Let me know what you all think; suggestions are welcome. Thanks!

Screenshot 2023-05-16 at 02 47 51 Screenshot 2023-05-16 at 02 48 08

Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built locally. (Sidenote: I recently migrated https://ngff.openmicroscopy.org/ away from GH Pages and to RTD in order to be able to review PRs)

One additional observation: the side TOC is getting hard to visually parse:

Specification
Description
Applications
Adopters
Office Hours
Features
Implementations
Sponsorship
Slides
Videos
ZEPs
Community
Blog

Time to go alphabetical? Perhaps bring back the split but call it "Subpages" rather than "other sites".

implementations/index.md Outdated Show resolved Hide resolved
implementations/index.md Outdated Show resolved Hide resolved
implementations/index.md Outdated Show resolved Hide resolved
@MSanKeys963
Copy link
Member Author

Thanks for the feedback, @joshmoore.

Sidenote: I recently migrated https://ngff.openmicroscopy.org/ away from GH Pages and to RTD in order to be able to review PRs

Interesting. Does that mean RTD would be able to render the minimal-mistakes theme or it would build the page in RTD default theme only?

This is what the implementations page and sidebar currently look like:

Screenshot 2023-05-16 at 23 12 21

Let me know if there are any more suggestions.

@joshmoore
Copy link
Member

Interesting. Does that mean RTD would be able to render the minimal-mistakes theme or it would build the page in RTD default theme only?

I imagine so, but I did not try that.

sidebar currently look like:

Looks more usable to me. What do you think?

implementations page

Interesting. I was thinking a table like this:

| Name     | Language | Something else (stars? link?) |
|----------|----------|-------------------------------|
| NetCDF-C | C        | establied 1999                |
| GDAL     | C++      |                               |
| JZarr    | Java     |                               |
| etc      |          |                               |

but this would work, too. Readability should probably be the top prio.

@MSanKeys963
Copy link
Member Author

MSanKeys963 commented May 16, 2023

I imagine so, but I did not try that.

I lightly doubt it. Maybe RTD can render sphinx-themes only?

Looks more usable to me. What do you think?

Yes, looks good.

I was thinking a table like this:

I tried doing something like this, but the minimal-mistakes theme has limited horizontal space, and it gets crumbled when you try to fit in too much.
I suggest going ahead with this for now, and then we can add more stuff later by switching themes.

@joshmoore
Copy link
Member

Maybe RTD can render sphinx-themes only?

Definitely not. You do have to install the package though.

I suggest going ahead with this for now, and then we can add more stuff later by switching themes.

👍

@MSanKeys963
Copy link
Member Author

Definitely not. You do have to install the package though.

I see. I'll look into this further.

Merging this for now. 🚀

@MSanKeys963 MSanKeys963 merged commit 444e1cf into zarr-developers:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants