-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Lint javascript for license header and add licence to js files #843
base: develop
Are you sure you want to change the base?
[WIP] Lint javascript for license header and add licence to js files #843
Conversation
Signed-off-by: J.Veldhuijzen <[email protected]>
Signed-off-by: J.Veldhuijzen <[email protected]>
cad2da9
to
0198356
Compare
* | ||
* ZAP is an HTTP/HTTPS proxy for assessing web application security. | ||
* | ||
* Copyright $YEAR The ZAP Development Team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has the year as token.
// FIXME: remove after #620 | ||
// eslint-disable-next-line no-unsanitized/property |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be reverted.
Changed to WIP per above comments. |
@jveldhuijzen do you still plan to work on this? |
Well.. it's been busy. Where I left this off was that the lib used to to the linting (and fixing the header) wasn't able to do a replacement of the So yeah, I'll try that project out in a linux vm to see where it leads me with the unit testing. |
Thank you. |
As you may've wondered, I'm not getting around fixing this the right way. So I'll leave this PR for someone else to continue upon or do you guys want to close this? |
Its funny, I've been looking for something like this for JS (after building it in rust over at https://github.com/tauri-apps/tauri ) - I have a couple cycles free this week and can pick this one up if you like @thc202 |
That sounds good to me, I guess you would have to create a new PR (as you'll not be able to change this?). We can leave it open in the meantime though. |
Would you prefer a proper SPDX approach? If so, who is the exact copyright holder? |
I don't think it needs to be but if it addresses the issue. We go with "The ZAP Development Team". |
Adds license header files to javascript and lints the javascript files.
Fixes #1