Init to http://zap/ #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Bennetts <[email protected]>
Signed-off-by: aryangupta701 <[email protected]>
Signed-off-by: Aryan Gupta <[email protected]>
|
any idea why firefox and chrome send different report objects for the exact same code? |
Signed-off-by: aryangupta701 <[email protected]>
|
woohoo.. I wonder why they don't pass in my local setup. Is this same with you @psiinon ? |
|
Will check... |
|
Passes except for the Firefox test for me locally, but that fails without this change so I think its ok.. |
thc202
approved these changes
Oct 23, 2023
|
Thank you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.