Record enter key presses in input fields #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thc202
reviewed
Nov 27, 2024
psiinon
force-pushed
the
record/enter
branch
2 times, most recently
from
c3e5583
to
edae2f8
Compare
|
Added integration test, and fixed a problem with dup events that the test uncovered 😁 |
This comment was marked as resolved.
This comment was marked as resolved.
psiinon
changed the title
|
Ready for review |
Signed-off-by: Simon Bennetts <[email protected]>
psiinon
force-pushed
the
record/enter
branch
from
edae2f8
to
ab2ddb8
Compare
thc202
approved these changes
Nov 28, 2024
|
Thank you! |
kingthorin
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to add integrations tests.
Pushed early as the integration tests dont all pass for me, but I think thats a local issue..
The ZestComment support isnt strictly needed, but I added it to help me debug something, and it could be useful in the future?