chore: review comments

zalando · Apr 7, 2024 · 4bb8c8e · 4bb8c8e
1 parent c3b244c
commit 4bb8c8e
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/internal/insight/insight.go b/internal/insight/insight.go
@@ -72,6 +72,7 @@ func (in *Insight) Fetch(ctx context.Context, dbiResourceId string, dur time.Dur
 	samples := map[string]Samples{}
 	var wg sync.WaitGroup
 	var err error
+	var mu sync.Mutex
 
 	for _, chunk := range chunks {
 		chunk := chunk
@@ -81,8 +82,12 @@ func (in *Insight) Fetch(ctx context.Context, dbiResourceId string, dur time.Dur
 			defer wg.Done()
 
 			set, e := in.fetch(childContext, dbiResourceId, dur, chunk...)
+
+			mu.Lock()
+			defer mu.Unlock()
+
 			if e != nil {
-				if e != context.Canceled {
+				if err == nil {
 					cancel()
 					err = e
 				}