Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoscaler: ensure HPA min replicas is not below Stack replicas #441

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AlexanderYastrebov
Copy link
Member

Users may scale stack manually via kubectl scale stack which updates Stack spec.replicas but it would not work when HPA is present and has lower minReplicas value.

This change ensures that Stack's HPA min replicas is not below Stack spec.replicas (if present).

Signed-off-by: Alexander Yastrebov [email protected]

Users may scale stack manually via `kubectl scale stack` which updates
Stack `spec.replicas` but it would not work when HPA is present and has
lower minReplicas value.

This change ensures that Stack's HPA min replicas is not below Stack
`spec.replicas` (if present).

Signed-off-by: Alexander Yastrebov <[email protected]>
// clientsetscheme "k8s.io/client-go/kubernetes/scheme"
// aggregatorclientsetscheme "k8s.io/kube-aggregator/pkg/client/clientset_generated/clientset/scheme"
// )
// import (
Copy link
Member Author

@AlexanderYastrebov AlexanderYastrebov Oct 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is due to go1.19 formatting changes

@szuecs
Copy link
Member

szuecs commented Oct 25, 2022

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants