Switch from radix to blueprint #780
Conversation
Yes let's have our own component using the style override you made. Let's make it such that it has the exact same API as the blueprint RadioGroup component. Also let's name it differently to avoid name clashes: |
Deploying react-science with
|
| Latest commit: |
b11684f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ada0de97.react-science.pages.dev |
| Branch Preview URL: | https://switch-from-radix-to-bluepri.react-science.pages.dev |
|
@stropitek this PR is ready |
|
The hovered style of radio buttons is missing (vs. on the main branch) |
There was a problem hiding this comment.
Please make the height and font size of the radio button component similar to other form components.
- Regular: 30px height and 14px font size (using
remunit) - Large: 40px height and 16px font size (using
remunit)
Please provide a commit message with the list of breaking change.
There was a problem hiding this comment.
There is a regression in the sticky accordion headers of the info panel.
CleanShot.2024-11-04.at.09.04.06.mp4
The height should be 30px / 40px including the borders. It should be the same size next to a text input.
Do your commit messages include all the breaking changes or will you provide a commit message with all the breaking changes in the PR thread?
They Include all breaking changes |
Should |
No does not have to be |
|
The content does not look centered now (it's too low), and there is a double border on the selected item.
|
|
ping @wadjih-bencheikh18 Will you be able to finish this? |
closes : #469
For the RadioGroup component, I created the same we have with BluePrintJs
Either we update ours and make it use BluePrintJs instead of radix or just remove the component because it can be done using BluePrintJs
Technically I prefer we update ours because recreating it with BluePrintJs is not simple.
https://switch-from-radix-to-bluepri.react-science.pages.dev/stories/?path=/story/forms-radio--control-button
https://switch-from-radix-to-bluepri.react-science.pages.dev/stories/?path=/story/components-infopanel--basic