Moved pythonlibs to module_utils to avoid usage of ENV vars #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amatamalas looks good. Tests are passing. Can you just remove the "export" line from the ./run_this.sh since we don't need to use that anymore. |
|
nice work. this was on our todo list. |
senorsmile
reviewed
Dec 6, 2017
| @@ -55,15 +55,15 @@ | |||
| password: "{{ mt_pass }}" | |||
| state: present | |||
| parameter: filter | |||
| settings: | |||
| rule: | |||
There was a problem hiding this comment.
is this a fix or a potential improvement?
There was a problem hiding this comment.
That change was included by mistake as it should not be part of the PR. This change is because the modules is not using "settings" but "rule" as the dictionary that contains the elements to be added/removed to the module. This should be part of another PR for issue #14
|
@zahodi I will add the change and commit it. Thanks for pointing that out! |
|
lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have rerun the test with simply using the following command without any ENV var:
ansible-playbook tests.yml --diff -i 127.0.0.1,