Fix word-spacing adjustment (#69) #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two improvements: - Line 267: iteration is now going up to 20px. Before it was only 3px which wasn't enough in some cases. In my tests it took never more then 5px to exceed the maxWidth. So 20px should be fine (also for long words) - Line 147, 163: For browsers with no support for subpixel font scaling, it seems to be necessary to round the values, because they might get rounded incorrectly. At least my Safari (6.1.6) took 0.9px for 0px
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two improvements:
which wasn't enough in some cases. In my tests it took never more then
5px to exceed the maxWidth. So 20px should be fine (also for long
words)
it seems to be necessary to round the values, because they might get
rounded incorrectly. At least my Safari (6.1.6) took 0.9px for 0px