added a from_string method to HumanHasher #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets you make calls like:
>>> humanhash.from_string("humanhash")
'asparagus-oven-minnesota-hamper'
|
Hi, sorry for digging this up after three years. I'm the maintainer of the Python3 compatible fork on PyPI. I'm curious: why did you pick DNS for the namespace? And uuid3 vs. uuid5? |
|
Inexperience 😄 What's the correct namespace? |
|
No judgment - I don't know what a better option is, I just wanted to hear your reasoning behind it. Nowadays I would probably shy away from uuid3 because MD5 is pretty broken, but uuid5 isn't much better because SHA-1 is also (more recently) broken. And uuid4 is right out because it's not repeatable. 😕 So I don't really know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets you make calls like:
Which helped with some of my purposes (needing a human-readable tag for another human-readable string, but for them to be semantically unrelated)