Convert db init/upgrade job: pre-install/pre-upgrade #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of some reported issues with ArgoCD or helm using the `--wait` flag, a change in the way the initialization job for database access and schema works has been implemented: - job is now of type pre-install / pre-upgrade - changed to use Kubernetes API access only when upgrading (otherwise serviceAccount would not be available) - migrated the images needed for the job + for the HA labels sidecar to be residing in Github Repos inside this same organization (from a private Gitlab) and images being built with Github Actions - removed the init containers waiting for database access, these are not needed anymore due to the "pre-install/pre-upgrade" approach
2 tasks
|
I'll merge this one now. Let's wait a little bit until we have #141 fixed as well. I'll going to look into it right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of some reported issues with ArgoCD or helm using the
--waitflag, a change in the way the initialization job for database access and schema works has been implemented:Which issue this PR fixes
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]