Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string escapes. (issue #37) #54

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Commits on Oct 14, 2014

  1. Fix string escapes. (issue zaach#37)

    Previously the different escape characters were being applied one after the other, so that "\\n" in the json will get turned into a new-line instead of "\n".
    Previously unicode escapes were not being converted resulting in stringifying the parse result turning "\u20AC" getting turned into "\\u20AC".
    Previously "\/" was not being converted resulting in stringifying the parse result turning it into "\\/"
    
    Note: I removed handling of '\v' because this would not be accepted by the lexer anyway, and is not part of the json standard.
    Note: Because unicode escapes are converted, strings in the input like "\u20AC" will become their unicode equivalent after parsing (e.g. in this case the euro character).
    
    Also changed the command line use of JSON.stringify to further process the result to convert non-ASCII printable characters to unicode escapes.  While not strictly necessary according to the JSON standard, ascii output is safer for some parsers, and now that the parser processes unicode escapes there is more chance of having non-ASCII characters in the parser output.
    I would suggest that it would be better to always use formatter.js instead of JSON.stringify, because that way the choice between unicode escaped values and unicode characters would always be the same for input and output.  Similar formatting changes should probably be made in the web version.
    ntdaley committed Oct 14, 2014
    Configuration menu
    Copy the full SHA
    ecf1830 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aaf81b1 View commit details
    Browse the repository at this point in the history