replace nomnom with commander #367
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice to see this merged, in order to avoid warnings! |
| @@ -18,7 +18,7 @@ Jison can be installed for [Node](http://nodejs.org) using [`npm`](http://github | |||
|
|
|||
| Using npm: | |||
|
|
|||
| npm install jison -g | |||
| npm install jison --global --unsafe_perm --allow_root | |||
There was a problem hiding this comment.
Hey, sorry to be annoying, and it seems like this project might be unmaintained anyway, but is this part necessary to use commander instead? Just curious, I was trying to find the nomnom dependency in CoffeeScript and found this PR which I really appreciate and trying to understand if this affects how jison needs to be installed is all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installation steps doesn't work anymore because
nomnomis apparently deprecated and no longer maintained. They suggest usingcommanderin their README. This PR updates the files required to make it work again.