Always remove the token stack label #352
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_token_stack label was only removed when `token-stack` option was present.
GerHobbelt
added a commit
to GerHobbelt/jison
that referenced
this pull request
Apr 9, 2017
zaach#352 as we now use a different mark-and-strip approach, which does not use JS labels anymore at all. Thus flagged as processed. # Conflicts: # lib/jison.js
GerHobbelt
added a commit
to GerHobbelt/route-parser
that referenced
this pull request
Sep 5, 2017
// Remove _token_stack label manually until fixed in jison: // zaach/jison#351 // zaach/jison#352
|
Ran into this recently, can this fix be merged? |
|
Would really like to see this merged as it's preventing me from bundling a project with webpack :( |
MoOx
added a commit
to MoOx/reduce-css-calc
that referenced
this pull request
Jan 22, 2018
|
Anything missing here? Any way to help out? |
|
For those who are still seeing this issue, seven years in, I worked around this by creating a script to replace the CLI: const cli = require('jison/lib/cli')
// This is a workaround for https://github.com/zaach/jison/pull/352 having never been merged
const oldProcessGrammars = cli.processGrammars
cli.processGrammars = function () {
const grammar = oldProcessGrammars.apply(this, arguments)
grammar.options = grammar.options ?? {}
grammar.options['token-stack'] = true
return grammar
}
cli.main({
file: '', // TODO: Add your file path here
outfile: '', // TODO: Add your output path here
// TODO: Add any other options you want here
'token-stack': true,
}) |
omervk
added a commit
to omervk/gamgee
that referenced
this pull request
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_token_stack label was only removed when
token-stackoption was present.