Enabling use of ebnf-parser in production code #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of package.json. Changed path to jison module to point to latest official release instead of GitHub URL.
… generator dependency.
|
@PawelDefee Ran into the same thing you did with |
|
+1 can this get merged? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"npm install ebnf-parser" will now install dependencies from npm repository. Also changed jison reference to point to npm release.
Use case / why this would be good:
An open-source project I want to use, node-proto2json, depends on jison. It has not been updated for a while and I wanted to bring all its dependencies up to date. Since ebnf-parser was split out from jison a long time ago, this meant some code changes and package.json update.
However, ebnf-parser defines its dependencies as "dev" only so that installing it as dependency via npm repository will not work correctly. This pull request aims to fix this issue.