Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to node 12 and update packages' #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

christensena
Copy link

Azure Functions v3 supports Node 12 which is now LTS

This PR makes changes needed so it will install and run on Node 12.

I also bumped package versions just by running npm audit fix --force
and deleted and recreated package-lock.json.

It seems to work fine.

updated nvmrc
updated packages per npm's vulnerability fix option (with force)
@codecov-commenter
Copy link

Codecov Report

Merging #36 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #36   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           67        67           
  Branches        18        18           
=========================================
  Hits            67        67           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bd9041...acf2de8. Read the comment docs.

@javierlinked
Copy link

As azure will deprecate azure-tools v2, and v3 requires node@12. I will have to fork this PR.

@theLAZYmd
Copy link

Ridiculous that we are a year later and this hasn't been resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants