Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type of a constant value #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix type of a constant value #3

wants to merge 1 commit into from

Conversation

piyo7
Copy link

@piyo7 piyo7 commented Mar 20, 2014

The type of "val a" in dA.scala is Double.
However, the type of "1 / n_visible" is Int.
Undesirable Implicit type conversion may occur as following example.

scala> val a : Double = 1 / 2
a: Double = 0.0

@Wei-1
Copy link

Wei-1 commented Nov 18, 2016

BTW, the file RBM.scala has the same bug at line 22.
This bug will cause the weighting variable W be all 0 while initialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants