Skip to content

Commit

Permalink
Merge pull request #273 from yujiosaka/use-docker-image-for-headless-…
Browse files Browse the repository at this point in the history
…chrome-crawler

test(ci): use docker image for headless chrome crawler
  • Loading branch information
yujiosaka authored Jun 10, 2018
2 parents 430eb3d + 0696aa4 commit 159402c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 10 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: 2
jobs:
build:
docker:
- image: yujiosaka/headless-chrome-linux
- image: yujiosaka/headless-chrome-crawler-linux
- image: redis
steps:
- checkout
Expand Down
9 changes: 0 additions & 9 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,5 @@ RUN chmod +x /usr/local/bin/dumb-init
# Install puppeteer so it's available in the container.
RUN yarn add headless-chrome-crawler

# Add user so we don't need --no-sandbox.
RUN groupadd -r crawler && useradd -r -g crawler -G audio,video crawler \
&& mkdir -p /home/crawler/Downloads \
&& chown -R crawler:crawler /home/crawler \
&& chown -R crawler:crawler /node_modules

# Run everything after as non-privileged user.
USER crawler

ENTRYPOINT ["dumb-init", "--"]
CMD ["google-chrome-unstable"]

0 comments on commit 159402c

Please sign in to comment.