fix the wrong behavior with a kobuki model on Gazebo5. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The plugin isn't working on Gazebo5 before, so that this PR is necessary aid for avoiding the wrong behavior with ROS Jade. Can you review this one, and then merge it? |
|
@bit-pirate Poke |
|
First, thanks for the contribution @DaikiMaekawa ! For Kobuki (and TurtleBot) we only support long-term releases, so no Jade. However, I don't want your contribution to be wasted, so I have created a jade branch. Please rebase this PR against the jade branch. |
|
@bit-pirate done. #43 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#41 I modified to not use SetMaxForce method.