iolib: fix different behavior in read function #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x501D
force-pushed
the
gh-455-fix-read
branch
2 times, most recently
from
8d78ab6
to
f90ee64
Compare
$ lua
Lua 5.1.5 Copyright (C) 1994-2012 Lua.org, PUC-Rio
> file = "/tmp"
> fd, _, code = io.open(file, "r")
> _, _, ecode = fd:read(1)
> print(ecode)
21
>
gopher-lua throws an exception:
read /tmp: is a directory
stack traceback:
[G]: in function 'read'
extra/wrapper.lua:17: in function 'exec'
<string>:1: in main chunk
[G]: ?
This patch results in behavior similar to the vanilla lua
implementation.
Closes yuin#455
0x501D
force-pushed
the
gh-455-fix-read
branch
from
f90ee64
to
5b5b27f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$ lua
Lua 5.1.5 Copyright (C) 1994-2012 Lua.org, PUC-Rio
gopher-lua throws an exception:
read /tmp: is a directory
stack traceback:
[G]: in function 'read'
extra/wrapper.lua:17: in function 'exec'
:1: in main chunk
[G]: ?
This patch results in behavior similar to the vanilla lua implementation.
Closes #455